Revert "Don't create Date or Calendar objects for ASN.1 dates unless needed" #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…needed. (google#1176)" Reason: Unexpected behaviour change which rejects certificates with invalid date files using UTCTIME with an offset, of which it turns out there are many in circulation. Also added a regression test to ensure we don't accidentally start rejecting them again.
sbgoog
approved these changes
Mar 20, 2024
miguelaranda0
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1176
Reason: Unexpected behaviour change which rejects certificates with invalid date files using UTCTIME with an offset, of which it turns out there are many in circulation.
Also added a regression test to ensure we don't accidentally start rejecting them again.